fix: prevent SQL/SOQL injection in Snowflake and Salesforce templates - #764
Merged
Merged
Conversation
Snowflake: Add identifier validation for database, schema, and table parameters that are interpolated into SQL statements. Rejects values that don't match Snowflake's unquoted identifier rules. Salesforce: Add Salesforce ID format validation (15/18 char alphanumeric) for record ID and accountId parameters. Add SOQL escaping for free-text string values like lead status. Add field name validation to prevent injection via crafted field arrays. Both templates construct queries via string interpolation where parameterized queries are not supported by the respective APIs. Allowlist validation is the standard mitigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/^[A-Za-z_][A-Za-z0-9_]*$/) fordatabase,schema, andtableparameters interpolated into SQL inlistSchemas,listTables,describeTable, andgetTableRowCountgetSingleRecord,listContacts,listOpportunities, andlistLeadsBoth APIs don't support parameterized identifiers, so allowlist validation is the standard mitigation.
Found via Aikido SAST scan — these are the real critical findings from a batch of 319 issues (96% false positive rate).
Test plan
veryfront generate integration snowflakeveryfront generate integration salesforcefoo; DROP TABLE)my_database,PUBLIC)